rusackas commented on code in PR #44362:
URL: https://github.com/apache/superset/pull/44362#discussion_r4083200891
##########
superset/charts/api.py:
##########
@@ -479,8 +479,7 @@ def get(self, id_or_uuid: str) -> Response:
result = self.chart_get_response_schema.dump(dash)
if resolver := current_app.config.get("EXTRA_OWNERS_RESOLVER"):
result["extra_owners"] = resolver(dash)
- if current_app.config.get("EXTRA_EDITORS_RESOLVER"):
- result["extra_editors"] = get_extra_editor_subject_ids(dash)
+ attach_extra_editors(result, dash)
Review Comment:
Good catch. Wrapped the resolver call in `get_extra_editor_subject_ids` so a
failure there just skips `extra_editors` instead of 500ing the whole response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
