rusackas commented on PR #44470: URL: https://github.com/apache/superset/pull/44470#issuecomment-5801818319
Thanks @chadek, this all checks out. The `generation === 0` gate plus handing a superseded token to a document that has none covers both directions of that race, and the handshake probe keeps stray navigations from minting tokens. Tests are flat now too. LGTM! On the test rig, I'd keep it as its own PR so this one stays just the fix. And yes, a refreshed description would be appreciated since the probe and `PortClosedError` bits aren't in it yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
