rusackas commented on PR #43376: URL: https://github.com/apache/superset/pull/43376#issuecomment-5801958296
Thanks for sticking with this one @jsk1004ha, looks like the review threads are all closed out. One thing I'd like a second opinion on before this lands: the Stats tab exposes row counts, cache hits, and response size to anyone with just `can_view_query`, which that role didn't see before. Seems harmless to me, but @michael-s-molina and @villebro, any concerns there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
