codeant-ai-for-open-source[bot] commented on code in PR #44011:
URL: https://github.com/apache/superset/pull/44011#discussion_r4086802872
##########
tests/unit_tests/common/test_query_context_processor.py:
##########
@@ -2220,6 +2220,34 @@ def
test_raise_for_access_evaluates_access_before_validate():
query.validate.assert_not_called()
+def test_raise_for_access_wraps_template_error_for_query_datasource():
+ """
+ When the datasource is a SQL Lab Query and raise_for_access() Jinja-renders
+ malformed SQL, the raw jinja2 TemplateError must be wrapped in
+ SupersetTemplateException (422) instead of leaking as an unhandled 500.
+ """
+ from jinja2.exceptions import TemplateSyntaxError
+
+ from superset.exceptions import SupersetTemplateException
+ from superset.utils.core import DatasourceType
+
+ query = MagicMock()
+ query_context = MagicMock()
+ query_context.queries = [query]
+ query_context.datasource.type = DatasourceType.QUERY
+
+ processor = QueryContextProcessor(query_context)
+
+ with patch(
+
"superset.common.query_context_processor.security_manager.raise_for_access",
+ side_effect=TemplateSyntaxError("unexpected end of template",
lineno=1),
+ ):
+ with pytest.raises(SupersetTemplateException):
+ processor.raise_for_access()
Review Comment:
**Suggestion:** The test checks only the exception class, so it passes even
if `SupersetTemplateException.status` is not 422 and cannot protect the API
contract this change targets.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3488617627e3492690bc2ad9c699b45d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3488617627e3492690bc2ad9c699b45d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/common/test_query_context_processor.py
**Line:** 2245:2246
**Comment:**
*Api Mismatch: The test checks only the exception class, so it passes
even if `SupersetTemplateException.status` is not 422 and cannot protect the
API contract this change targets.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44011&comment_hash=c622b52547c19f6cbc26cabd4eae419a2f6b4f615d577a82aabc6e986d983b39&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44011&comment_hash=c622b52547c19f6cbc26cabd4eae419a2f6b4f615d577a82aabc6e986d983b39&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
