rusackas commented on code in PR #40679:
URL: https://github.com/apache/superset/pull/40679#discussion_r4086934081
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/types.ts:
##########
@@ -23,6 +23,11 @@ export interface SliceHeaderControlsProps {
description: string;
viz_type: string;
slice_name: string;
+ // The name as rendered in the header: the localized value, or the panel's
+ // own title override. Used for strings the viewer reads; slice_name stays
+ // the canonical value for edits, filenames and extension payloads.
+ // Kept in step with the copy of this interface in ./index.tsx.
+ display_name?: string;
Review Comment:
Same duplication is already on `master`, this PR just adds `display_name` to
both copies. @alex-poor already declined collapsing the two in the other Bito
thread and I agree that is its own change, not something to fold into a SIP PR.
Resolving this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
