aminghadersohi commented on code in PR #43723:
URL: https://github.com/apache/superset/pull/43723#discussion_r4087126362
##########
superset/examples/video_game_sales/charts/Games.yaml:
##########
@@ -32,7 +32,7 @@ params:
color_pn: false
datasource: 21__table
granularity_sqla: year
- groupby:
+ columns:
Review Comment:
`columns` is not a control in plugin-chart-table (`controlPanel.tsx`
declares `groupby` + `all_columns`). `groupby: [name]` is the retained
aggregate-mode Dimensions value (`resetOnHide: false`), so switching this chart
to Aggregate now starts empty.
```suggestion
groupby:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
