Re: [PR] chore(cypress): remove dead dashboard drill-to-detail Cypress suite [superset]

Wed, 23 Sep 2026 13:50:52 -0700 


codeant-ai-for-open-source[bot] commented on code in PR #44537:
URL: https://github.com/apache/superset/pull/44537#discussion_r4087154928


##########
superset-frontend/cypress-base/cypress/e2e/explore/utils.ts:
##########
@@ -17,7 +17,9 @@
  * under the License.
  */
 
-import { interceptGet as interceptDashboardGet } from '../dashboard/utils';
+export function interceptDashboardGet() {
+  cy.intercept('GET', '**/api/v1/dashboard/*').as('get');
+}

Review Comment:
   **Suggestion:** The wildcard also matches `/api/v1/dashboard/?q=...`, which 
the save modal requests before saving, so `cy.wait('@get')` can consume the 
list request instead of the dashboard detail response.
   
   **Assessment:** ๐ŸŸ  `Major` ยท ๐Ÿ” `Occurrence: Often` ยท ๐Ÿท๏ธ `Api mismatch`
   
   [![Use CodeAnt 
Skill](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/use-codeant-skill-flat-v2.svg)](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
 [![Fix in 
Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9c725e0a21b341dfbc31213c86a39f73&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
 [![Fix in VSCode 
Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9c725e0a21b341dfbc31213c86a39f73&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   <details>
   <summary><b>Prompt for AI Agent ๐Ÿค– </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset-frontend/cypress-base/cypress/e2e/explore/utils.ts
   **Line:** 20:22
   **Comment:**
        *Api Mismatch: The wildcard also matches `/api/v1/dashboard/?q=...`, 
which the save modal requests before saving, so `cy.wait('@get')` can consume 
the list request instead of the dashboard detail response.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve 
this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask 
user if the user wants to fix the rest of the comments as well. if said yes, 
then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44537&comment_hash=45b259c7be159ebd06d98c16c15046bed1fca4ebaf653a152a404ae11aba8455&reaction=like'>๐Ÿ‘</a>
 | <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44537&comment_hash=45b259c7be159ebd06d98c16c15046bed1fca4ebaf653a152a404ae11aba8455&reaction=dislike'>๐Ÿ‘Ž</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to