deepujain commented on PR #44557: URL: https://github.com/apache/superset/pull/44557#issuecomment-5802993850
Addressed both additional suggestions in [Bito review #c475fe](https://github.com/apache/superset/pull/44557#issuecomment-5789658627). The initialization sentinel is now null, so an absent dashboard ID cannot satisfy the render gate before hydration. The comment now explains that the grid waits for hydration and color initialization. The new regression fails on the previous head because the grid mounts before hydration, then passes after the fix and verifies mounting after the dashboard ID arrives. All 20 DashboardContainer tests and the full plugin build pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
