EnxDev commented on code in PR #44584:
URL: https://github.com/apache/superset/pull/44584#discussion_r4087872892
##########
pyproject.toml:
##########
@@ -455,6 +455,9 @@ select = [
"F",
"G",
"I",
+ # f-strings passed to gettext are never translatable, and on Python
+ # 3.12+ babel extracts bogus msgids from their replacement fields.
+ "INT001",
Review Comment:
INT001 only checks `_`, `gettext` and `ngettext` by default, so `__(f"...")`
still slips through, even though `__` is one of the `-k` keywords babel
extracts. I checked it with `ruff --select INT001` on a scratch file.
Nothing in `superset/` uses `__` that way at the moment, so it's not
blocking. Worth adding `extend-function-names = ["__"]` under
`[tool.ruff.lint.flake8-gettext]` so the guard matches what babel extracts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
