shivaansh0610-LUFFY commented on issue #44079: URL: https://github.com/apache/superset/issues/44079#issuecomment-5807733305
Ah nice, thanks for the heads up! @piyushraj001 mind if I ask - does #44044 also cover the SQL Lab side of this, where `BigInt()` chokes on a value already in scientific notation (like `3.21...e+28`)? Looking at the PR it seems to normalize bigint -> Number once a BigInt already exists and hits the formatters, which is exactly what #44007 needed, but the crash in this issue happens earlier, when `BigInt()` itself fails to parse the string during parsing. Not sure if that's the same code path or a separate one. Happy to hold off either way, just want to make sure I'm not duplicating work if it's already covered, or stepping on toes if it's not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
