omsn2 commented on PR #43108: URL: https://github.com/apache/superset/pull/43108#issuecomment-5808334022
> @omsn2 heads up, I rebased this onto `master` so the merge commits are gone. One thing I changed along the way: the last `master` merge had dropped the `useDashboardFilterSync` call in `DashboardPage.tsx` (the MCP filter-apply bit from #44096, unrelated to this PR), so the "unused import" cleanup was papering over a regression. I put the call and import back. Holler if that was intentional. Thanks for catching that and doing the rebase, @rusackas! No, dropping it wasn't intentional at all. It looks like an earlier merge conflict resolution accidentally dropped the actual useDashboardFilterSync() hook call from the component body. Because the call was missing, oxlint started failing CI complaining about an unused import, so the import was just removed to get CI green—papering over the dropped call without realizing it. Great catch putting them both back! The rebase looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
