bito-code-review[bot] commented on PR #44397: URL: https://github.com/apache/superset/pull/44397#issuecomment-5816954583
<!-- Bito Reply --> The issue is correct. While `scripts/translations/babel_update.sh` was updated to include `--add-comments=i18n:`, the documentation in `docs/developer_docs/contributing/howtos.md` does not provide the command to execute this script, and the existing extraction commands mentioned in the documentation do not include this flag, meaning the comments are not being extracted as expected. To resolve this, update the documentation to explicitly instruct developers to run the `babel_update.sh` script instead of running `pybabel extract` manually. Would you like me to implement this documentation fix? I can also check the rest of the PR for other comments if you would like me to address them as well. **docs/developer_docs/contributing/howtos.md** ### Updating language files ```bash ./scripts/translations/babel_update.sh ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
