rusackas commented on code in PR #44553:
URL: https://github.com/apache/superset/pull/44553#discussion_r4095952912
##########
tests/integration_tests/dashboards/soft_delete_tests.py:
##########
@@ -389,6 +389,9 @@ def test_restore_soft_deleted_dashboard(self) -> None:
self.client.delete(f"/api/v1/dashboard/{dashboard_id}")
rv = self.client.post(f"/api/v1/dashboard/{dashboard_uuid}/restore")
assert rv.status_code == 200
+ # the UUID route still resolves to the archived row's integer id
+ log = self.get_latest_log("DashboardRestApi.restore")
+ assert log.dashboard_id == dashboard_id
Review Comment:
Done, added the same two lines to `test_purge_by_owner_permanently_deletes`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
