bito-code-review[bot] commented on code in PR #44392:
URL: https://github.com/apache/superset/pull/44392#discussion_r4097284335
##########
superset-frontend/packages/superset-ui-core/src/components/DeleteModal/types.ts:
##########
@@ -47,8 +47,10 @@ export interface DeleteModalProps {
* otherwise `'danger'`. Same precedence as `primaryButtonName`.
*/
primaryButtonStyle?: ButtonStyle;
- /** Disable confirmation independently of the typed-text gate. */
+ /** Disable the primary action independently of the typed-text gate. */
disablePrimaryButton?: boolean;
+ /** Disable the confirmation input and primary action when deletion is
blocked. */
+ disableConfirmationInput?: boolean;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Misleading prop name</b></div>
<div id="fix">
`disableConfirmationInput` also disables the primary action via
`confirmationBlocked` (index.tsx:56-57), overlapping `disablePrimaryButton`.
The DatabaseList consumer sets both to the same value (index.tsx:1333-1336),
showing the overlap is confusing. A name like `disableConfirmation` would
reflect that it gates the whole flow.
</div>
</div>
<small><i>Code Review Run #f0493f</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
