bito-code-review[bot] commented on PR #44626:
URL: https://github.com/apache/superset/pull/44626#issuecomment-5824704562

   <!-- Bito Reply -->
   The flagged issue is correct. Exempting all `SecurityRestApi` endpoints from 
forced password changes can allow users with a pending password change to 
access restricted functionality, such as generating a guest token, if they have 
the necessary permissions. 
   
   To resolve this, you should narrow the exemption to only the specific 
endpoints required for the password change flow (e.g., `PUT /api/v1/me/`) 
rather than the entire `SecurityRestApi` blueprint. This ensures that other 
sensitive endpoints remain protected by the forced password change requirement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to