EnxDev commented on code in PR #44645:
URL: https://github.com/apache/superset/pull/44645#discussion_r4103470468
##########
superset/models/helpers.py:
##########
@@ -3771,6 +3771,7 @@ def get_from_clause(
self.schema or default_schema or "",
statement,
exclude_dataset_id=self_id,
+ include_global_guest_rls=False,
Review Comment:
Follow-up is up in #44650 (stacked on this one). It injects the global guest
rules into tables read inside sub-queries of the virtual SQL (scalar, IN,
EXISTS, and CTEs they read), and keeps leaving FROM, join, derived table and
LATERAL reads to the outer filter, so the #37395 double application stays
fixed. Joins stay as they are; closing that case would break every virtual
dataset that joins a lookup table without the rule's column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
