mikebridge commented on PR #44514: URL: https://github.com/apache/superset/pull/44514#issuecomment-5840420355
Thanks, Evan. I pushed `f3f75b3f` to address both remaining findings. `_capture_enabled()` now passes the request Session explicitly, matching the restore path. The previous fallback resolved to that same request Session, so this makes the dependency explicit without changing the session lifecycle. Config loading and `prune_old_versions()` now use one retention resolver; malformed canonical or legacy values warn and defer pruning with `0` instead of failing the task. Tests cover the session bindings, invalid values, and the legacy ambiguity case. I also made a predicate result of `None` a memoized false decision. We are intentionally retaining documented `-1` immediate eligibility; unchanged-save reconciliation remains a follow-up. The local affected tests and required hooks passed, and fresh CI is running on this head. Could you re-review when convenient? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
