FrancescoCastaldi commented on PR #44464: URL: https://github.com/apache/superset/pull/44464#issuecomment-5854654062
Thanks for the thorough review! All points addressed in 81af1e5b: - **Schema & coercion**: Delegated top-level pair coercion in \coerce_sort_by\ to \_coerce_sort_item(v)\ to eliminate duplication, documented the pair format in the field description, and simplified \dd_xy_sort_config\ to rely on the pre-coerced \SortByConfig\. - **Temporal handling**: Guarded \_build_single_query_dict\ against overriding chronological ordering with \x_axis_sort\ when temporal indicators (\granularity_sqla\, \ ime_grain_sqla\, or \mixed_timeseries\) are present. - **Metric & dimension matching**: Normalized aggregate aliases (\STDDEV\ / \VAR\) in \_match_y_metric_label\ and aligned x-axis dimension targeting with \getXAxisLabel\ in \sortOperator.ts\. - **Tests & typing**: Added docstrings and explicit local type annotations across \ est_dataset_validator.py\, \ est_chart_utils.py\, \ est_chart_helpers.py\, and \ est_chart_schemas.py\, removed the duplicate test case in \ est_chart_schemas.py\, and verified clean passes across Ruff and all 449 unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
