FrancescoCastaldi commented on code in PR #44464:
URL: https://github.com/apache/superset/pull/44464#discussion_r4116821671
##########
superset/mcp_service/chart/schemas.py:
##########
@@ -2569,6 +2588,34 @@ class XYChartConfig(BaseChartConfig):
ge=1,
le=10000,
)
+ sort_by: SortByConfig | str | List[SortByConfig | str] | None = Field(
+ None,
+ description=(
+ "Sort specification for the chart. Accepts a SortByConfig object, "
+ "a bare column/metric name string (defaults to descending), a "
+ "[column, ascending] pair, or a single-item list containing
either. "
+ "Multi-column sorting is not supported for XY charts."
+ ),
Review Comment:
Thanks a lot for spotting this and for the suggestion @aminghadersohi!
Applied in commit \81a94cc\ and verified: all unit-tests and the full CI suite
are now 100% green.
##########
superset/mcp_service/chart/schemas.py:
##########
@@ -2569,6 +2588,34 @@ class XYChartConfig(BaseChartConfig):
ge=1,
le=10000,
)
+ sort_by: SortByConfig | str | List[SortByConfig | str] | None = Field(
+ None,
+ description=(
+ "Sort specification for the chart. Accepts a SortByConfig object, "
+ "a bare column/metric name string (defaults to descending), a "
+ "[column, ascending] pair, or a single-item list containing
either. "
+ "Multi-column sorting is not supported for XY charts."
+ ),
Review Comment:
Thanks a lot for spotting this and for the suggestion @aminghadersohi!
Applied in commit `81a94cc` and verified: all unit-tests and the full CI suite
are now 100% green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
