gabotorresruiz commented on code in PR #44618:
URL: https://github.com/apache/superset/pull/44618#discussion_r4137071146
##########
superset/mcp_service/chart/plugins/bubble.py:
##########
@@ -103,7 +103,7 @@ def resolve_viz_type(self, config: Any) -> str:
return "bubble_v2"
def normalize_column_refs(self, config: Any, dataset_context: Any) -> Any:
- config_dict = config.model_dump()
+ config_dict = config.model_dump(exclude_unset=True)
Review Comment:
Not a blocker and nothing to change here: this one word also repairs two
adjacent bubble behaviours, which I measured on both commits.
Because `filters` was always in `model_fields_set` on the parent,
`_inherited_state_invalid_keys` in `update_chart.py` never treated a saved
`adhoc_filters` as inherited state, so rebinding a bubble chart to a dataset
that lacks the filtered column carried the stale predicate over untouched. The
same input returns `{'adhoc_filters'}` on this branch and drops it. Separately,
an update that set `temporal_column` and omitted `filters` used to replace a
saved `TEMPORAL_RANGE` of `Last month` on `Start` with a generated `No filter`,
because `preserve_previous_adhoc_filters` never ran for bubble. It runs now and
the saved range survives.
Both are wins, so the only ask is a line in the summary so the wider scope
is on record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
