aminghadersohi commented on PR #44321: URL: https://github.com/apache/superset/pull/44321#issuecomment-5903409707
One more commit, bed9e88e90, found while capturing the screenshots now in the description. It is not one of the review asks. ECharts' `overflow: 'truncate'` only keeps text that fits in `width - 1` (zrender `parseText`: `containerWidth - 1 // Reserve some gap`). With the label box sized to exactly `ceil(measured width)`, the widest category name always lost its last glyph: "User Acceptance Testing" measured 142px and rendered as "User Acceptance Testi…". The fix reserves that 1px. The new test fails without it and passes with it. Names past the 25% width cap are still truncated with an ellipsis. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
