bito-code-review[bot] commented on PR #44816:
URL: https://github.com/apache/superset/pull/44816#issuecomment-5903666931
<!-- Bito Reply -->
The issue is valid. The `partition_column` field is missing from the
`DatasetInfo` Pydantic schema, causing it to be dropped during serialization.
To resolve this, you need to add `partition_column` to the `DatasetInfo` schema
definition in `superset/mcp_service/common/schema_discovery.py` (or the
relevant schema file).
Here is the suggested fix:
```python
# Add this to the DatasetInfo properties
"partition_column": {
"description": "The physical column the engine partitions on",
"type": "string",
"nullable": true
},
```
I have checked the PR and there are no other pending review comments. Would
you like me to proceed with any other tasks?
**superset/mcp_service/common/schema_discovery.py**
```
"partition_column": {
"description": "The physical column the engine partitions on",
"type": "string",
"nullable": true
},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
