bito-code-review[bot] commented on PR #44818:
URL: https://github.com/apache/superset/pull/44818#issuecomment-5904043953
<!-- Bito Reply -->
The flagged issue is correct. The PR already addresses this by centralizing
temporal parsing in `coerceTemporalMs` within
`superset-frontend/plugins/plugin-chart-echarts/src/utils/formatters.ts`. This
function ensures that date-only strings are parsed as local midnight,
consistent with ECharts' behavior, and it is now used by both `getXAxisDomain`
and `getTemporalTickValues` to ensure consistency across the chart's x-axis and
annotations.
As there are no other comments in the provided PR context, no further fixes
are required.
**superset-frontend/plugins/plugin-chart-echarts/src/utils/formatters.ts**
```
export function coerceTemporalMs(value: unknown): number {
// eslint-disable-next-line no-nested-ternary
return value instanceof Date
? value.getTime()
: typeof value === 'string'
? parseTemporalString(value)
: Number(value ?? NaN);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
