younsl commented on PR #394: URL: https://github.com/apache/superset-kubernetes-operator/pull/394#issuecomment-5915759469
Thanks for the review @villebro! All comments are addressed: - Dropped the dnsPolicy None nameserver guard and its test, leaving validation to the API server (4335480, 255deb0) - Removed the default value reference from the dnsPolicy schema description (8c48648) - Added the corev1.PodDNSConfig type link for dnsConfig (39af319) - Took the nit in this PR: all optional string values in the chart now default to ~ instead of "", and the schema accepts null. Explicit empty strings still validate, and default rendered manifests are unchanged (65676cc) PTAL when you have a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
