rusackas commented on PR #44800: URL: https://github.com/apache/superset/pull/44800#issuecomment-5916097712
This is a lot to absorb in one pass, most of the later commits close gaps an adversarial review found in the first version. Design seems solid: header the model never sees, refuse rather than widen. It's billed as correctness-only, not an authorization boundary, but the SQL rewrite in `dashboard_scope_sql.py` overlaps enough with RLS's own job that I'd want a second pair of eyes on that file before this merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
