sadpandajoe opened a new pull request, #44829: URL: https://github.com/apache/superset/pull/44829
### SUMMARY All Cypress E2E coverage now lives in Playwright, so the `cypress-matrix` CI job was setting up, building and installing Cypress only to run zero specs. This removes the remaining Cypress infrastructure: - **Deleted:** `superset-frontend/cypress-base/`, `cypress_build.sh`, `scripts/cypress_run.py`, `docker/docker-entrypoint-initdb.d/cypress-init.sh`. - **CI:** removed the `cypress-matrix` and `cypress-matrix-required` jobs and the `use_dashboard` dispatch input from `superset-e2e.yml`, the `cypress-*` functions from `bashlib.sh`, the Cypress cache, and the labeler entries. `cypress-matrix-required` is dropped from the required checks in `.asf.yaml`. The gunicorn rationale comments now live in `playwright-run`, which previously pointed at the deleted Cypress function. - **Docker/env:** removed `CYPRESS_PORT` / `CYPRESS_CONFIG` handling from `docker-compose.yml`, the docker init/bootstrap scripts, `superset_config.py`, env files and `docker-compose-up.sh`, plus the `build-cypress` / `open-cypress` Make targets. - **Build/lint config:** removed `cypress-base` from oxlint, eslint, webpack, pre-commit, custom rules and the source-tree scanner. - **Code:** removed the `window.Cypress` guard around the dashboard `beforeunload` listener; nothing sets it anymore. - **Docs:** removed the deprecated Cypress sections from the contributing, testing and agent guides. `build-instrumented` and the instrumented-assets cache are kept because the Playwright job still uses them. Historical comments in tests, versioned docs and changelogs are left as-is. Note for merge: `cypress-matrix-required` is listed in master's required checks in `.asf.yaml`, and this PR removes both the job and that entry. If the requirement blocks merge before the `.asf.yaml` change applies, a temporary no-op job under that name can be added and removed in a follow-up. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TESTING INSTRUCTIONS - CI: the `playwright-tests` matrix and `playwright-tests-required` still run and pass; no Cypress job is produced. - `pre-commit run` passes on the changed files (including zizmor and the frontend type check). - `npx jest src/dashboard/components/DashboardBuilder` passes. - `docker compose up` still initializes the admin user and loads examples without `CYPRESS_CONFIG`. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [x] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
