sadpandajoe commented on code in PR #44696:
URL: https://github.com/apache/superset/pull/44696#discussion_r4147805206
##########
.github/dependabot.yml:
##########
@@ -95,6 +107,21 @@ updates:
fontsource:
patterns:
- "@fontsource/*"
+ docusaurus:
+ patterns:
+ - "@docusaurus/*"
+ docusaurus-openapi:
+ patterns:
+ - "docusaurus-plugin-openapi-docs"
+ - "docusaurus-theme-openapi-docs"
+ monorepo-dependencies:
+ group-by: dependency-name
+ patterns:
+ - "webpack"
+ - "@types/node"
+ - "oxfmt"
+ - "oxlint"
+ - "oxlint-tsgolint"
open-pull-requests-limit: 30
Review Comment:
Merging these four directories into one `directories:` entry doesn't turn
`open-pull-requests-limit: 30` into a shared cap — Dependabot applies it
independently per directory (reproduced in dependabot/dependabot-core#10395: 26
directories with `limit: 10` produced 26 simultaneous open PRs, one per
directory). That raises `/docs` from 10 to 30 and
`/superset-websocket`/`/superset-embedded-sdk` from Dependabot's documented
default of 5 to 30 each, working against the goal of reducing CI load. Should
each directory keep closer to its original narrower limit instead?
##########
.github/dependabot.yml:
##########
@@ -49,7 +52,11 @@ updates:
# hold comments). Remove this once the proxy code is updated to await
# the async decompress() API.
- dependency-name: "simple-zstd"
- directory: "/superset-frontend/"
+ directories:
Review Comment:
This entry's `ignore:` block was written for superset-frontend's specific
constraints (e.g. holding React majors until the app supports React 19, holding
Babel 8 for frontend plugin compatibility), but now also covers `/docs` and
`/superset-embedded-sdk` since they share this entry. `/docs` (React/React DOM
^18.3.1) had no prior ignore list and could previously receive a React-major
update; `/superset-embedded-sdk` (@babel/core already ^8.0.5) had no prior
Babel ignore. Both will now silently skip major updates they were previously
eligible for, for reasons that don't apply to them. Should the ignore list stay
scoped to `/superset-frontend`, or is broadening it to all four intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
