mikebridge commented on code in PR #44396:
URL: https://github.com/apache/superset/pull/44396#discussion_r4147922273
##########
superset/commands/chart/export.py:
##########
@@ -74,7 +75,9 @@ def _file_content(model: Slice) -> str:
logger.info("Unable to decode `params` field: %s",
payload["params"])
payload["version"] = EXPORT_VERSION
- if model.table:
+ if model.datasource_type == "semantic_view":
+ payload["datasource_ref"] =
export_view_reference(model.semantic_view)
Review Comment:
Thanks—confirmed and fixed in `f4d029a33a`. A missing view no longer aborts
mixed chart exports; the same guard covers orphaned dashboard filter/display
targets. Red-first tests cover both feature states and preserve import
rejection of incomplete references. Existing views still require feature,
access and provider checks. All 147 affected tests pass.
##########
UPDATING.md:
##########
@@ -24,6 +24,15 @@ assists people when migrating to a new version.
## Next
+- Semantic-view chart and dashboard bundles use typed UUID references and
require
Review Comment:
Documented both compatibility directions in `f4d029a33a`: older readers
cannot consume typed semantic references, and older semantic dashboard bundles
without `datasourceRef` must be re-exported. We reject them rather than binding
their local IDs to unrelated tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
