aminghadersohi commented on code in PR #44455: URL: https://github.com/apache/superset/pull/44455#discussion_r4148856113
########## docs/docs/using-superset/exploring-data.mdx: ########## @@ -24,6 +24,21 @@ The following information about each flight is given: - Information about the origin and destination. - The distance between the origin and destination, in kilometers (km). +### Semantic Table time grains + +For a Table chart backed by a semantic view, Time Grain applies when grouping by +a temporal dimension. Removing the last temporal dimension leaves the saved +choice intact, but the frontend omits a recognized dormant grain from aggregate +requests whose selected columns are known to be non-temporal (including no +grouping columns). Adding the temporal dimension again reuses the saved choice. +Unknown columns or grain values are not silently normalized. Ordinary dataset +charts and raw-record queries are unchanged. + +This applies to requests rebuilt by the updated frontend in Explore and +dashboards; it does not rewrite saved charts. Direct API requests and saved Review Comment: Dashboards use saved `temporal_columns_lookup` and never rerun `initialValue`, so a chart saved before this change has no `false` entries: `groupby: ['country']` still sends P1D (probed). Only metric-only charts are fixed until re-saved in Explore. ```suggestion This applies to requests rebuilt by the updated frontend in Explore and dashboards; it does not rewrite saved charts. Grouped charts saved before this change lack non-temporal column metadata, so dashboards keep their grain until the chart is re-saved in Explore. Direct API requests and saved ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
