rusackas commented on PR #38028: URL: https://github.com/apache/superset/pull/38028#issuecomment-5924981268
Heya! This one needs more than a normal rebase, `legacy-preset-chart-deckgl` got folded into `preset-chart-deckgl` on `master` back in #38035, so the whole H3Hexagon layer needs to move into that package instead. The good news is it's mostly mechanical: `preset-chart-deckgl/src/layers/Hex/` has the exact same file shape, and every shared helper you're importing (`common.tsx`, `factory.tsx`, `TooltipRow.tsx`, `utilities/tooltipUtils.tsx`, `utilities/Shared_DeckGL.tsx`, `utils.ts`) still lives at the same relative path, so most imports shouldn't need touching. `h3-js` is also already a transitive lockfile dependency close to the version you want, so it should dedupe cleanly once it's a direct dependency of the new package. One thing that needs removing rather than porting: #42126 stripped the whole JS-eval customization feature (`js_data_mutator`/`js_tooltip`/`js_onclick_href`/`js_columns`) from every deck.gl layer. `H3Hexagon.tsx`, `controlPanel.ts`, `buildQuery.ts` and `transformProps.ts` all still reference it, that'll need to come out along with the "Advanced" control section. While you're in there, a few of the open threads are still real and worth fixing. The cross-filter click handler throws, since H3 form data doesn't have any of the fields `getCrossFilterDataMask` needs, easiest fix is just not wiring `emitCrossFilters` for this layer, matching CodeAnt's suggested fallback. `getPoints` only samples each hexagon's first boundary vertex for auto-zoom, so edge hexagons get clipped. A tooltip/JS column literally named `hexagon` or `elevation` clobbers the internal field of the same name in `transformProps.ts`. The NULL filter on `h3_index` passes just the column label, so it gets rejected for an ad-hoc expression, needs the raw column object instead. The zero-value-renders-transparent one is actually a pre-existing bug in the shared `getBreakPointColorScaler` in `utils.ts` (`if (!v)` treats a legit `0` metric as missing), not something specific to this layer. DamianPendrak's color-scheme-type selector ask looks already done, just never got marked resol ved. Setting this to draft for now given the scope. Holler if you want a hand with any of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
