john-bodley commented on a change in pull request #8724: handle nulls in bar
chart series/breakdown
URL:
https://github.com/apache/incubator-superset/pull/8724#discussion_r353430900
##########
File path: superset/connectors/druid/models.py
##########
@@ -1363,7 +1364,7 @@ def homogenize_types(df: pd.DataFrame, groupby_cols:
Iterable[str]) -> pd.DataFr
Here we replace None with <NULL> and make the whole series a
str instead of an object.
"""
- df[groupby_cols] = df[groupby_cols].fillna("<NULL>").astype("unicode")
+ df[groupby_cols] =
df[groupby_cols].fillna(NULL_STRING).astype("unicode")
Review comment:
Somewhat unrelated to your change but we probably don't need the
`.astype("unicode")` as in Python 3 all strings are unicode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
