rusackas commented on PR #43303: URL: https://github.com/apache/superset/pull/43303#issuecomment-5943343565
Thanks @eugeneo17, CI looks green now. Before another pass, the adhoc-filter fail-closed change and the `sort_by_metric` / fallback `where` and `extra_filters` cases from @sadpandajoe still look open to me. Could you reply or resolve each thread once it's handled? I'd also lean toward splitting the V8 bundle and `mini-racer` dependency into its own PR/SIP, as you offered. That would let the dependency-free synthesis land on its own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
