mikebridge opened a new pull request, #44874: URL: https://github.com/apache/superset/pull/44874
### SUMMARY Check purge-policy eligibility before the scheduled task scans soft-deleted rows. Unsupported models remain untouched and are reported once per run through an additive `unsupported_models` result, a warning, and a metric. Supported policies, retention windows, cascades and visibility filtering are unchanged; no new policy-registration API is added. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Backend-only. Before: aged rows in unsupported models produce repeated cascade failures or inflate dry-run counts. After: the task skips these models before scanning and reports each once, while supported models continue processing. ### TESTING INSTRUCTIONS From the repository root, use the test virtual environment and configured disposable SQLite metadata/examples databases with the standard integration fixtures, then run: `python -m pytest tests/unit_tests/tasks/test_deletion_retention.py tests/unit_tests/commands/deletion_retention tests/unit_tests/cli/deletion_retention_test.py -q --tb=short --show-capture=no -p no:cacheprovider` `python -m pytest tests/integration_tests/deletion_retention -q -rs --tb=short --show-capture=no -p no:cacheprovider` Unit coverage includes empty/one/three-row unsupported models and mixed supported/unsupported runs in live and dry modes. Unit result: 275 passed. SQLite integration on the unchanged production implementation: 120 passed, 2 skipped (SQLite lacks REPEATABLE READ; timing protocol is opt-in). Changed-file hooks pass. PostgreSQL/MySQL and full repository suites were not run. ### ADDITIONAL INFORMATION Requires the existing `SOFT_DELETE` feature flag and a valid, nonzero retention window. No UI changes, database migration, new API or API removal. No public GitHub issue linked. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
