rusackas commented on issue #41268:
URL: https://github.com/apache/superset/issues/41268#issuecomment-5944826943

   Circling back on this one. I think it's fixed, and I've got a regression 
test to back that up rather than just a guess.
   
   The "View as table" results grid gets its column labels from `GET 
/api/v1/dataset/<pk>/drill_info/`, the same endpoint Drill to detail uses. 
#43719 (merged after your last reply here) fixed two real bugs in that exact 
path: the endpoint's schema had no `metrics` field at all and narrowed 
`columns` to dimensions only, so a chart like yours (a `COUNT` metric plus a 
`contribution` post-processing column) got back a verbose map missing both; and 
separately, the fetch that feeds those labels was gated behind Drill to detail 
specifically rather than the actual `can_view_chart_as_table`/`can_explore` set 
"View as table" is offered to.
   
   I rebuilt your exact scenario as a test: a role with 
`can_view_chart_as_table` and `can_get_drill_info` but not `can_explore` (you'd 
granted `can_explore_json`, which is a different permission), against a chart 
shaped like yours, asserting the real results grid (not a mock) actually 
renders the rows and row count end to end -- and that it doesn't get stuck 
loading even if `drill_info` itself fails. Both pass on current master: 
https://github.com/apache/superset/pull/44881
   
   #43719 hasn't shipped in a tagged release yet, so if you're still on 6.1.0 
you won't have it. Worth a retest once it's in a release (or against 
`master`/an RC if you want to check sooner) -- if it's still broken there, 
reopen and I'll take another look, ideally with the Network tab capture for the 
actual "View as table" click specifically (the one you shared earlier looks 
like the chart's own initial render, not the results pane's own fetch).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to