aminghadersohi commented on PR #44893: URL: https://github.com/apache/superset/pull/44893#issuecomment-5963463134
Thanks for the thorough review. Addressed the blocking item and both non-blocking suggestions in 606d7f022f2a3ca323cb1b796b06e83153b111e2 (replied inline on each thread with specifics). On the `pre-commit` check: confirmed your read independently. The mypy \`no-redef\` on \`superset/commands/importers/v1/utils.py:202\` is still present on current \`apache/superset\` master (checked at its current tip), introduced by #44390 and unrelated to the files this PR touches — mypy's whole-import-graph analysis surfaces it even when only this PR's files are passed to the hook. Since master itself hasn't fixed it, merging master into this branch wouldn't help, so I've left it as-is; it isn't something this PR can or should fix. Full `tests/unit_tests/mcp_service` suite: 6,783 passed, 3 skipped, 0 failed at this head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
