sadpandajoe opened a new pull request, #44954:
URL: https://github.com/apache/superset/pull/44954
### SUMMARY
The vertical (sidebar) native filter bar renders each section — "Filters",
the "Filters out of scope" collapsible, and "Display controls" — as direct
children of a flex column that already applies a `gap` between them. One of
those sections also had its own `margin-bottom` on top of that gap, so the
two spacing rules stacked additively instead of collapsing: the space above
the "Filters out of scope" collapsible ended up around 20px instead of the
intended 8px used between every other pair of sections, making it look like
extra, unintended padding was being reserved there and pushing the following
"Display controls" section down more than necessary.
The fix removes the redundant per-section margin and lets the flex
container's `gap` be the single source of truth for spacing between
sections, so all section-to-section gaps are now consistent.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No live screenshot was captured for this change — it was verified via an
added regression test (`FilterControls.test.tsx`) that asserts on the
computed spacing, plus an independent code review, rather than a running
dev server.
### TESTING INSTRUCTIONS
- Open a dashboard that has native filters in the vertical/sidebar filter
bar layout, with at least one filter scoped out of the current tab (so the
"Filters out of scope" collapsible is visible) and another section (e.g.
"Display controls") rendered below it.
- Confirm the vertical spacing above the "Filters out of scope" row matches
the spacing used between the other sections (consistent ~8px gaps), rather
than a visibly larger gap.
- Alternatively, run the new automated test:
`npx jest
src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.test.tsx`
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
