Re: [PR] fix(explore): honor a controlled ControlPopover open prop [superset]

Sat, 03 Oct 2026 13:04:29 -0700 


codeant-ai-for-open-source[bot] commented on code in PR #44959:
URL: https://github.com/apache/superset/pull/44959#discussion_r4174640564


##########
superset-frontend/src/explore/components/controls/ControlPopover/ControlPopover.tsx:
##########
@@ -84,15 +84,17 @@ const ControlPopover: FC<PopoverProps> = ({
   getPopupContainer,
   getVisibilityRatio = getElementVisibilityRatio,
   open: visibleProp,
+  defaultOpen,
+  onOpenChange,
   destroyOnHidden = false,
   placement: initialPlacement = 'right',
   autoAdjustOverflow,
   ...props
 }) => {
+  const isControlled = visibleProp !== undefined;
   const triggerElementRef = useRef<HTMLElement>();
-  const [visible, setVisible] = useState(
-    visibleProp === undefined ? props.defaultOpen : visibleProp,
-  );
+  const [uncontrolledVisible, setUncontrolledVisible] = 
useState(!!defaultOpen);

Review Comment:
   **Suggestion:** The test setup mocks every `useState` setter except the 
placement setter; this new state therefore cannot change, so existing 
uncontrolled popover tests remain permanently closed.
   
   **Assessment:** ๐ŸŸ  `Major` ยท ๐Ÿ” `Occurrence: Often` ยท ๐Ÿท๏ธ `Possible bug`
   
   [![Use CodeAnt 
Skill](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/use-codeant-skill-flat-v2.svg)](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
 [![Fix in 
Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9a47ad4fa16141a692344d375871be7f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
 [![Fix in VSCode 
Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9a47ad4fa16141a692344d375871be7f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   <details>
   <summary><b>Prompt for AI Agent ๐Ÿค– </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** 
superset-frontend/src/explore/components/controls/ControlPopover/ControlPopover.tsx
   **Line:** 96:96
   **Comment:**
        *Possible Bug: The test setup mocks every `useState` setter except the 
placement setter; this new state therefore cannot change, so existing 
uncontrolled popover tests remain permanently closed.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve 
this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask 
user if the user wants to fix the rest of the comments as well. if said yes, 
then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44959&comment_hash=5f28b488ffda50e65af88bd8d57f44a843cdac5f583d5f51aaebf29f466737aa&reaction=like'>๐Ÿ‘</a>
 | <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44959&comment_hash=5f28b488ffda50e65af88bd8d57f44a843cdac5f583d5f51aaebf29f466737aa&reaction=dislike'>๐Ÿ‘Ž</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to