codeant-ai-for-open-source[bot] commented on code in PR #44966:
URL: https://github.com/apache/superset/pull/44966#discussion_r4180219930
##########
superset-frontend/src/explore/components/controls/ContourControl/ContourPopoverControl.tsx:
##########
@@ -50,7 +50,10 @@ const isIsoband = (contour: ContourType) => {
if (Object.keys(contour).length < 4) {
return false;
}
- return contour.upperThreshold && contour.lowerThreshold;
+ return (
+ (contour.upperThreshold || contour.upperThreshold === 0) &&
+ (contour.lowerThreshold || contour.lowerThreshold === 0)
+ );
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `9fbc8bf`.
The popover now determines the active tab with `isIsoband`, which checks
whether both thresholds are present, including zero. `getTabKey` uses that same
check to select the isoband tab.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
