kokhlo commented on issue #44981: URL: https://github.com/apache/superset/issues/44981#issuecomment-5990535015
Thanks for the exact diagnosis — the value really does reach the browser, so this is purely a frontend consumption gap. My read of the code path: the refresh dropdown builds its options from a module-level hard-coded array, so `bootstrap.common.conf.DASHBOARD_AUTO_REFRESH_INTERVALS` is never read by the bundle. The regression is consistent with the auto-refresh rework (#37459) splitting the old server-driven option list out of the config path. Plan: - Have the selector derive its options from `bootstrap.common.conf.DASHBOARD_AUTO_REFRESH_INTERVALS` when that value is a non-empty list of `[value, label]` pairs, falling back to the current hard-coded list when the key is absent (older embedded/bootstrapped payloads) or malformed, so nothing breaks on a partial bootstrap. - Respect the `0` / "Don't refresh" entry from config rather than always prepending it, matching the 6.0.x behaviour. - Add a focused frontend test pinning both branches (config present → config options; config absent → hard-coded fallback). I'll verify against `master` (not 6.1.0) and open a PR shortly. PR within the hour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
