kokhlo commented on PR #44701: URL: https://github.com/apache/superset/pull/44701#issuecomment-5992767724
You're right — flooring every no-grain tick throws away precision the series may actually carry. Reworked in 784b0fb to target the boundary label specifically, and dropped the shared-wrapper change in \`getSmartDateFormatter\` entirely (the no-grain path returns the raw base formatter again, as on master). The flooring now lives in a new \`createPaddedExtentFloorFormatter\` wired into the Timeseries and MixedTimeseries axes: it receives the data domain from \`getXAxisDomain\` and floors to the second **only ticks that fall outside that domain** — ECharts axis-extent padding. Ticks inside the domain pass through untouched. Verified through the real \`transformProps\` (Top-10-Games-shaped chart, temporal \`year\` column, no grain), same three ticks on each head: | tick | master | previous PR head | 784b0fb | |---|---|---|---| | padded max boundary (+943ms) | \`.943ms\` | \`2009\` | \`2009\` | | genuine in-domain (+500ms) | \`.500ms\` | \`2006\` | \`.500ms\` | | clean year tick | \`2009\` | \`2009\` | \`2009\` | Also rebased onto current master — the conflict with the new \`coerceTemporalMs\`/\`getXAxisDomain\` tests is resolved by keeping both sides (\`mergeable: true\`). Unit tests: formatters + Timeseries + MixedTimeseries suites, 518 passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
