sadpandajoe commented on code in PR #44933:
URL: https://github.com/apache/superset/pull/44933#discussion_r4187020649
##########
superset-frontend/src/explore/components/controls/ViewQueryModalFooter.tsx:
##########
@@ -87,7 +87,7 @@ const ViewQueryModalFooter: FC<ViewQueryModalFooterProps> =
(props: {
</Button>
<Button
buttonStyle="secondary"
- onClick={({ metaKey }) => openSQL(Boolean(metaKey))}
+ onClick={({ metaKey, ctrlKey }) => openSQL(Boolean(metaKey ||
ctrlKey))}
Review Comment:
Agreed—Ctrl-click now opens a new tab without the dataset or SQL: `postForm`
submits separate fields, but SQL Lab only imports the JSON in `form_data`.
Could this use the same serialized `form_data` payload as the datasource menu
and update the modifier-click tests to assert it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
