AmoghAtreya commented on code in PR #44957:
URL: https://github.com/apache/superset/pull/44957#discussion_r4187341631
##########
superset-frontend/src/explore/components/controls/ZoomConfigControl/ZoomConfigControl.tsx:
##########
@@ -72,7 +72,7 @@ export const ZoomConfigControl: FC<ZoomConfigsControlProps> =
({
}
const newValue = { ...value };
- newValue.configs.width = width;
+ newValue.configs = { ...newValue.configs, width };
newValue.values = computeConfigValues(newValue);
onChange(newValue);
Review Comment:
Addressed. `onBaseWidthChange` now calls `updateConfigs(value, { width })`,
so width uses the same immutable copy + recompute path as the other handlers.
##########
superset-frontend/src/explore/components/controls/ZoomConfigControl/ZoomConfigControl.tsx:
##########
@@ -84,16 +84,18 @@ export const ZoomConfigControl: FC<ZoomConfigsControlProps>
= ({
}
const newValue = { ...value };
- newValue.configs.height = height;
+ newValue.configs = { ...newValue.configs, height };
newValue.values = computeConfigValues(newValue);
onChange(newValue);
Review Comment:
Addressed. `onBaseHeightChange` now calls `updateConfigs(value, { height })`
instead of rebuilding `newValue` inline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
