codeant-ai-for-open-source[bot] commented on code in PR #43736:
URL: https://github.com/apache/superset/pull/43736#discussion_r4188586661
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ColumnSelect.tsx:
##########
@@ -143,14 +167,11 @@ export function ColumnSelect({
})}`,
})
.then(({ json: { result } }) => {
- const lookupValue = Array.isArray(value) ? value : [value];
- const valueExists = result.columns.some((column: Column) =>
- lookupValue?.includes(column.column_name),
- );
- if (!valueExists) {
+ if (!isValueInColumns(result.columns)) {
resetColumnField();
}
setColumns(result.columns);
+ onColumnsLoaded?.(filterColumnNames(result.columns));
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `018b691`.
The component tracks the latest datasource key and ignores semantic-view
responses when their request key is stale, preventing old columns from reaching
`onColumnsLoaded`.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
