mikebridge opened a new pull request, #44993: URL: https://github.com/apache/superset/pull/44993
### SUMMARY The dashboard access check resolves each member chart's datasource. Table and semantic-view charts come through their relationships with no extra query, but any other datasource type (in practice `query`-typed charts) fell through to one `DatasourceDAO` lookup per distinct datasource. This batches those lookups: one query per datasource type, made when the gate first needs them. Unchanged: relationship resolution first, typed de-duplication, chart order, short-circuiting on the first accessible member, and fail-closed handling (an unresolvable datasource is still inaccessible). No access decision is cached. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A. In the counting regression, three distinct `query` datasources go from three SELECTs to one. ### TESTING INSTRUCTIONS - Dashboard, security and subjects unit suites. - The new tests compare access decisions case by case: table and semantic-view members with colliding numeric IDs, missing or unsupported references, permission-less datasources, allowed and denied `query` members, early relationship grants, and a fresh lookup after deletion. - Not covered: very large batches and concurrency on non-SQLite databases. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
