bito-code-review[bot] commented on PR #44949: URL: https://github.com/apache/superset/pull/44949#issuecomment-6006848388
<!-- Bito Reply --> The suggestion to add a `data_at_top_level: bool` flag to `StatementInfo` is a reasonable way to make the distinction between statements explicit, especially since the current implementation relies on the client inferring the relationship from `original_sql`. Given that the current design already handles this by setting `data` to `null` for the last data-bearing statement and providing the results at the top level, adding this flag would improve clarity for clients. Since you mentioned it is fine to leave as is, no immediate action is required, but this remains a valid enhancement for future consideration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
