gabotorresruiz commented on code in PR #44901:
URL: https://github.com/apache/superset/pull/44901#discussion_r4190598935
##########
superset/db_engine_specs/clickhouse.py:
##########
@@ -478,24 +511,36 @@ class ClickHouseConnectEngineSpec(BasicParametersMixin,
ClickHouseEngineSpec):
"for ClickHouse. It provides automatic scaling, built-in "
"backups, and enterprise security features."
),
- "logo": "clickhouse.png",
+ "logo": "clickhouse-mark.svg",
+ "logo_dark": "clickhouse-mark-dark.svg",
"homepage_url": "https://clickhouse.cloud/";,
"categories": [
DatabaseCategory.ANALYTICAL_DATABASES,
DatabaseCategory.CLOUD_DATA_WAREHOUSES,
DatabaseCategory.HOSTED_OPEN_SOURCE,
],
- "pypi_packages": ["clickhouse-connect>=0.13.0"],
+ "pypi_packages": ["clickhouse-connect>=1.8.0,<2.0"],
"connection_string": (
"clickhousedb://{username}:{password}@{host}:8443/{database}?secure=true"
),
"parameters": {
- "username": "ClickHouse Cloud username",
- "password": "ClickHouse Cloud password",
- "host": "Your ClickHouse Cloud hostname",
+ "username": (
+ "Database username from the service Connect dialog "
+ "(default: default)"
+ ),
+ "password": (
+ "URL-encoded database password from the service
Connect dialog"
+ ),
+ "host": "HTTPS hostname from the service Connect dialog",
"database": "Database name (default)",
},
- "docs_url": "https://clickhouse.com/docs/en/cloud";,
+ "docs_url": "https://clickhouse.com/docs/cloud";,
Review Comment:
Just a small question on this link: both the old
`https://clickhouse.com/docs/en/cloud` and this new
`https://clickhouse.com/docs/cloud` currently redirect to
`https://clickhouse.com/docs/cloud/clickhouse-private` ("ClickHouse Private
Documentation"), which is a different product than the Cloud service this entry
describes. When I tried it, `https://clickhouse.com/docs/cloud/get-started`
lands on "Get started with ClickHouse Cloud" and
`https://clickhouse.com/docs/cloud/overview` on the Cloud introduction. You
will know better which one is the stable landing page, so take this as a
pointer rather than a prescription.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
