mayuriphad commented on PR #44962: URL: https://github.com/apache/superset/pull/44962#issuecomment-6009803719
Thanks for the reviews. Since an unset extent is a real state (the tag renders "unset"), I marked `fixedZoom`, `fixedLatitude` and `fixedLongitude` as optional in `MapViewConfigs` and dropped the `as unknown as` cast from the test. The other usages already pass these through to props that accept `undefined`, but I couldn't run the full TypeScript check locally, so I'm relying on CI for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
