verdier commented on code in PR #45003:
URL: https://github.com/apache/superset/pull/45003#discussion_r4193891823
##########
superset-frontend/src/explore/components/ControlPanelsContainer.tsx:
##########
@@ -493,6 +493,7 @@ export const ControlPanelsContainer = (props:
ControlPanelsContainerProps) => {
if (
prevDatasource &&
prevDatasource.type !== DatasourceType.Query &&
+ !props.exploreState.skipDatasetChangeAlert &&
Review Comment:
Thanks for identifying the normal-then-skipped case. We clarified the
contract: this option skips opening a notification for its own transition; it
must not acknowledge an earlier notification, which may report settings already
lost. Automatically closing that notification would hide unacknowledged
information.
The amended implementation instead snapshots the notified transition. If a
later change skips notification, the earlier alert keeps its original
retained/lost-controls variant, explicitly describes a previous change, and
loses its Clear form action so it cannot modify the current settings. Continue
only acknowledges it. Tests cover both retained and lost controls, a different
transfer result on the skipped change, no additional scroll, acknowledgement
without form changes, and a subsequent normal alert. All 29 component tests and
pre-commit checks (including frontend type checking) pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
