codeant-ai-for-open-source[bot] commented on code in PR #44926:
URL: https://github.com/apache/superset/pull/44926#discussion_r4198796322
##########
superset/commands/deletion_retention/purge_policy.py:
##########
@@ -1015,6 +1019,32 @@ def delete_associations(
phase=ExecutionPhase.ASSOCIATIONS,
permission_name=None,
)
+ if policy.entity_type == "dataset":
+ _detach_dataset_charts(session, entity_id)
+
+
+def _detach_dataset_charts(session: Session, entity_id: int) -> None:
+ """Clear the datasource reference and permission fields of a purged
+ dataset's charts, as an ORM hard delete of the dataset leaves them.
+
+ A chart kept pointing at the purged id would keep the dataset's stale
+ permission, and would adopt any later dataset that reuses the id. Only
+ ``slices`` rows are updated; no chart is deleted. Runs after the
+ dangling-chart impact snapshot, inside the purge's transaction.
+ """
+ # avoid circular import: model listener registration imports neutral event
helpers
+ from superset.models.slice import Slice
+ from superset.utils.core import DatasourceType
+
+ slices: sa.Table = Slice.__table__ # pylint: disable=no-member
+ session.execute(
+ sa.update(slices)
+ .where(
+ slices.c.datasource_type == DatasourceType.TABLE.value,
+ slices.c.datasource_id == entity_id,
+ )
+ .values(datasource_id=None, perm=None, schema_perm=None,
catalog_perm=None)
+ )
Review Comment:
**Suggestion:** A chart save can commit after this UPDATE but before the
dataset DELETE; without a datasource foreign key or range lock, it can retain
stale permissions and rebind if the ID is reused.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Race condition`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=396c8d32d4dd43d1a8fea9be340e0cb9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=396c8d32d4dd43d1a8fea9be340e0cb9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/deletion_retention/purge_policy.py
**Line:** 1040:1047
**Comment:**
*Race Condition: A chart save can commit after this UPDATE but before
the dataset DELETE; without a datasource foreign key or range lock, it can
retain stale permissions and rebind if the ID is reused.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44926&comment_hash=6a40952926ffb9eafeefbb2bebceb39d07bda7cccd9a4e37c114caef77815d0d&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44926&comment_hash=6a40952926ffb9eafeefbb2bebceb39d07bda7cccd9a4e37c114caef77815d0d&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
