codeant-ai-for-open-source[bot] commented on code in PR #45029: URL: https://github.com/apache/superset/pull/45029#discussion_r4199509827
########## superset/tasks/version_history_retention.py: ########## @@ -351,8 +352,46 @@ def _chunked(items: list[int], size: int) -> Iterator[list[int]]: _METRIC_PREFIX: str = "superset.versioning.retention" +def _live_bearing_tables(tables: ShadowTables) -> list[sa.Table]: + """Return every shadow table that can anchor a live transaction.""" + live_bearing_tables: list[sa.Table] = [*tables.parent, *tables.child] + if tables.m2m is not None: + live_bearing_tables.append(tables.m2m) + return live_bearing_tables + + +def _count_prunable(cutoff: datetime, tables: ShadowTables) -> int: + """Count the full eligible transaction backlog without writing rows.""" + total: int = 0 + after_id: int = 0 + live_bearing_tables: list[sa.Table] = _live_bearing_tables(tables) + conn: sa.engine.Connection + with db.engine.connect() as conn: + while True: + window: _PruneWindow = _resolve_prune_window( + conn, cutoff, live_bearing_tables, after_id, _MAX_PRUNE_BATCH + ) + total += len(window.prunable) + if window.candidate_count < _MAX_PRUNE_BATCH: + return total + after_id = window.max_candidate_id Review Comment: **Suggestion:** A large dry run keeps one read transaction open across every candidate window; on MySQL, this pins its snapshot and delays cleanup of old row versions until the scan ends. **Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Performance` [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=0a16f8cdaf7b41999061cee4e8da89ba&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=0a16f8cdaf7b41999061cee4e8da89ba&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/tasks/version_history_retention.py **Line:** 369:377 **Comment:** *Performance: A large dry run keeps one read transaction open across every candidate window; on MySQL, this pins its snapshot and delays cleanup of old row versions until the scan ends. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45029&comment_hash=9d26eeef35bd42a0cee7968fc2cd2f96ab772d41c4b9838e15429e242c936c7c&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45029&comment_hash=9d26eeef35bd42a0cee7968fc2cd2f96ab772d41c4b9838e15429e242c936c7c&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
